-
Notifications
You must be signed in to change notification settings - Fork 113
Replace node-fetch to undici #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0233b76 to
e14fa1a
Compare
|
@douglowder Could you review this? |
|
I've fixed our test workflow to run on pull requests, so if you update your branch, all those required statuses will pass:
Sorry that we didn't have that set up already, thanks again for the contribution! |
d2d8422 to
5bbecf4
Compare
douglowder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
|
Any updates on this one? |
|
@joaoschaab no. |
|
@douglowder @nicknovitski @ide |
vonovak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I have taken a quick look, I'll still need to take a better look later.
For now please:
- kindly accept the suggestion, it simplifies the code a bit
- fill out the PR description - what's the motivation for the change, why so many changes to the test suite were needed, and anything else that comes to your mind. Anybody from the community who visits the PR should be able to get read some reasoning on this.
Thank you!
I filled out the PR description. Could you review it again? @vonovak |
nicknovitski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the need for the changes to the tests: msw doesn't work with an explicitly imported undici, but undici has a built-in mocking feature.
On the subject of documentation, this would be a breaking change, since the agent option now is an undici agent, not an http agent.
@nicknovitski |

Internal refactoring: Replace node-fetch with undici
Motivation
The primary objective of this refactoring is to modernize our HTTP request stack and align the library with the evolving Node.js ecosystem standards.