Skip to content

Conversation

@sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Aug 10, 2025

Why

eas workflow:run .eas/workflows/deploy-to-production.yml is quite long.

eas run deploy-to-production is ✨.

How

  • added an alias to the command
  • changed how we resolve workflow file path from input (to support deploy-to-production).

Test Plan

Claude wrote tests which look sensible. I ran easd run basic-test in my local project.

> ~/Developer/test-local/mobile (test-5 [$✘!?]) easd run basic-test
(node:59375) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Using workflow file from /Users/sjchmiela/Developer/test-local/mobile/.eas/workflows/basic-test.yml

@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@sjchmiela sjchmiela marked this pull request as ready for review August 10, 2025 09:58
@sjchmiela sjchmiela requested a review from douglowder August 10, 2025 09:58
@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@github-actions
Copy link

Size Change: +6.02 kB (+0.01%)

Total Size: 53.6 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.6 MB +6.02 kB (+0.01%)

compressed-size-action

Comment on lines +1 to +2
import path from 'path';
import { vol } from 'memfs';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import path from 'path';
import { vol } from 'memfs';
import { vol } from 'memfs';
import path from 'path';


export default class WorkflowRun extends EasCommand {
static override description = 'run an EAS workflow';
static override aliases = ['run'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have build:run, so I am a little concerned about customer confusion with adding the alias.

Copy link
Contributor

@douglowder douglowder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I am concerned about adding "run" as an alias to "workflow:run", since we also have "build:run". Maybe we can add that separately later, after a review of all the different commands under "workflow" and "build"....
Please fix the lint failure 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants