-
Notifications
You must be signed in to change notification settings - Fork 153
[eas-cli] Add eas run command
#3138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Thank you for adding the changelog entry! |
|
Subscribed to pull request
Generated by CodeMention |
|
Size Change: +6.02 kB (+0.01%) Total Size: 53.6 MB
|
| import path from 'path'; | ||
| import { vol } from 'memfs'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| import path from 'path'; | |
| import { vol } from 'memfs'; | |
| import { vol } from 'memfs'; | |
| import path from 'path'; |
|
|
||
| export default class WorkflowRun extends EasCommand { | ||
| static override description = 'run an EAS workflow'; | ||
| static override aliases = ['run']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have build:run, so I am a little concerned about customer confusion with adding the alias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I am concerned about adding "run" as an alias to "workflow:run", since we also have "build:run". Maybe we can add that separately later, after a review of all the different commands under "workflow" and "build"....
Please fix the lint failure 😃
Why
eas workflow:run .eas/workflows/deploy-to-production.ymlis quite long.eas run deploy-to-productionis ✨.How
deploy-to-production).Test Plan
Claude wrote tests which look sensible. I ran
easd run basic-testin my local project.