Skip to content

refactor: Replace remaining trivial dependencies #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 8, 2025

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 4, 2025

This replaces remaining dependencies in @expo/devcert, slimming it down to the bare essentials and aligning it with typical dependencies we already maintain in the mainline expo monorepo.

  • Replace password-prompt with node:readline
    • Note: This fixes some xterm bugs as well and behaves the same as before
  • Replace get-port with address check
    • Note: This wasn't actually used with an initial port. This is trivial since we're using the port on http.createServer and hence only need to add a callback to the .listen call
  • Replace eol package
    • Note: This is a trivial isWindows check and a search-and-replace (basically identical to eol)
  • Replace mkdirp with node:fs
  • Replace tmp package with node:os + node:fs + node:crypto
    • Note: pretty typical now in expo/expo too. The only difference is that we create a file here first
  • Replace lodash/template
    • Note: lodash.template was replaced by eta, but that said, we don't do complex templating, so we can replace this with some regexes
  • Vendor application-config-path
    • Note: This is never-changing process.env stuff and trivial to vendor
  • Remove tslib
    • Note: With Node 18 being assumed, only the default-import polyfill remains, which we can just let TypeScript inline
  • Replac command-exists
    • Note: A bit more complex, but it's safer to just scan PATH here (Windows support is also taken care of though)

@kitten kitten requested review from byCedric and EvanBacon March 4, 2025 23:00
@kitten kitten merged commit b0cb0d3 into master Apr 8, 2025
kitten added a commit to expo/expo that referenced this pull request Apr 8, 2025
# Why

Applies: expo/devcert#5

We don't bump `package.json` specified versions to not force our users
to update, in case something goes wrong with the new version.

# How

- Update `yarn.lock` files

# Test Plan

- n/a
betomoedano pushed a commit to expo/expo that referenced this pull request Apr 16, 2025
# Why

Applies: expo/devcert#5

We don't bump `package.json` specified versions to not force our users
to update, in case something goes wrong with the new version.

# How

- Update `yarn.lock` files

# Test Plan

- n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant