chore: Replace sudo-prompt with @expo/sudo-prompt fork
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
kitten
changed the title
sudo-prompt with @vscode/sudo-prompt forksudo-prompt with @expo/sudo-prompt fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related: expo/expo#34364
The
sudo-promptpackage has been deprecated. See: https://www.npmjs.com/package/sudo-promptA fork was maintained at: https://www.npmjs.com/package/@vscode/sudo-prompt
This in turn caused
utildeprecations, so a new fork with those fixed is at: https://www.npmjs.com/package/@expo/sudo-promptThis shouldn't have a large impact, but we should maybe look at replacing this package eventually. We didn't need to touch this in a while, so this is purely to solve npm and Node deprecations.
Set of changes
sudo-promptwith@vscode/sudo-prompt