Skip to content

Fix ResourceNotFound in chat model type for AzureOpenAI #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2023
Merged

Fix ResourceNotFound in chat model type for AzureOpenAI #337

merged 3 commits into from
Oct 20, 2023

Conversation

viveksilimkhan1
Copy link
Contributor

@viveksilimkhan1 viveksilimkhan1 commented Oct 20, 2023 •
edited
Loading

Description

Fix ResourceNotFoundError (#336) in chat model type for AzureOpenAI

Corresponding documentation PR

Types of change

Bug fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

rmitsch
rmitsch reviewed Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@rmitsch rmitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Just a minor change - if the tests pass, I'll merge this.

@rmitsch rmitsch added bug Something isn't working feat/model Feature: models Test external Run external tests labels Oct 20, 2023
rmitsch
rmitsch reviewed Oct 20, 2023
View reviewed changes
@rmitsch rmitsch linked an issue Oct 20, 2023 that may be closed by this pull request
ValueError: Request to Azure OpenAI API failed: Resource not found #336
Closed
@rmitsch rmitsch merged commit 7a0460c into explosion:main Oct 20, 2023
@rmitsch rmitsch mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmitsch rmitsch rmitsch left review comments

Assignees

No one assigned

Labels

bug Something isn't working feat/model Feature: models Test external Run external tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ValueError: Request to Azure OpenAI API failed: Resource not found

2 participants

@viveksilimkhan1 @rmitsch