Skip to content

Optional authentation verification at init time #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2023
Merged

Optional authentation verification at init time #206

merged 4 commits into from
Jul 11, 2023

Conversation

@rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Jul 7, 2023 •
edited
Loading

Description

Makes verification of authentication details at init time optional for REST models. Adds auth check at init time for Cohere and Anthropic models.

Corresponding documentation PR

todo (waiting for docs migration to spacy.io to be done first)

Types of change

Enhancement.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added enhancement Improvement of existing feature feat/model Feature: models labels Jul 7, 2023
@rmitsch rmitsch self-assigned this Jul 7, 2023
@rmitsch rmitsch marked this pull request as ready for review July 7, 2023 10:19
svlandeg
svlandeg reviewed Jul 11, 2023
View reviewed changes
svlandeg
svlandeg approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rmitsch rmitsch changed the base branch from main to develop July 11, 2023 10:07
@rmitsch rmitsch changed the base branch from develop to main July 11, 2023 10:07
@rmitsch rmitsch merged commit 85176ff into main Jul 11, 2023
@svlandeg svlandeg deleted the feat/optional-auth-verify branch July 11, 2023 10:15
rmitsch added a commit that referenced this pull request Jul 12, 2023
@rmitsch @svlandeg
Merge pull request #213 from explosion/main
9eef85d 
* Fix regex -> re import. (#205)

* Add 'gpu' marker. (#208)

* Optional authentation verification at init time (#206)

* Add verify_auth param.

* Add _verify_auth() for Cohere and Anthropic.

* Make auth check mandatory again.

* Remove redundant PR.

* Fix OpenLLaMA model names (#209)

* Update PR template. (#207)

* Update OpenLLaMA model names.

* fix model name in documentation (#210)

* Bump version to 0.4.1. (#211)

---------

Co-authored-by: Sofie Van Landeghem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@svlandeg svlandeg svlandeg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rmitsch rmitsch

Labels

enhancement Improvement of existing feature feat/model Feature: models

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rmitsch @svlandeg