Skip to content

Conversation

@rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Jun 23, 2023

Description

Check for inconsistency between specified labels and labels in examples.

Types of change

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added bug Something isn't working feat/task Feature: tasks labels Jun 23, 2023
@rmitsch rmitsch self-assigned this Jun 23, 2023
@rmitsch rmitsch changed the title Fix/label inconsistency Detect label inconsistency in SpanTask Jun 23, 2023
@rmitsch rmitsch changed the base branch from main to develop June 23, 2023 07:35
@rmitsch rmitsch marked this pull request as ready for review June 23, 2023 08:16
Copy link
Contributor

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need to think about how to handle such an inconsistency.

I think we should warn instead of error here though, and discard the examples that do not fall into the label list that was specified earlier. Basically that allows users to keep the list of examples fixed while playing with different labels for the LLM to recognize (sometimes adding/removing labels can influence accuracy within the same label category).

@svlandeg
Copy link
Contributor

I think the refactor is fine, but did you also see my other comment?

I think we should warn instead of error here though, and discard the examples that do not fall into the label list that was specified earlier. Basically that allows users to keep the list of examples fixed while playing with different labels for the LLM to recognize (sometimes adding/removing labels can influence accuracy within the same label category).

Basically I think we can recover by just keeping to the pre-defined list of labels, and discard the non-matching ones, while warning?

@rmitsch
Copy link
Collaborator Author

rmitsch commented Jun 29, 2023

Basically I think we can recover by just keeping to the pre-defined list of labels, and discard the non-matching ones, while warning?

Done in d2aadb3.

Copy link
Contributor

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Virtually good to merge, just two smaller comments

@rmitsch rmitsch merged commit dfd43fe into develop Jul 5, 2023
@svlandeg svlandeg deleted the fix/label-inconsistency branch July 5, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working feat/task Feature: tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants