-
-
Notifications
You must be signed in to change notification settings - Fork 104
Detect label inconsistency in SpanTask
#183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SpanTask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely need to think about how to handle such an inconsistency.
I think we should warn instead of error here though, and discard the examples that do not fall into the label list that was specified earlier. Basically that allows users to keep the list of examples fixed while playing with different labels for the LLM to recognize (sometimes adding/removing labels can influence accuracy within the same label category).
Co-authored-by: Sofie Van Landeghem <[email protected]>
…llm into fix/label-inconsistency
|
I think the refactor is fine, but did you also see my other comment?
Basically I think we can recover by just keeping to the pre-defined list of labels, and discard the non-matching ones, while warning? |
… containing only invalid labels.
Done in d2aadb3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Virtually good to merge, just two smaller comments
Description
Check for inconsistency between specified labels and labels in examples.
Types of change
Checklist
testsandusage_examples/tests, and all new and existing tests passed. This includespytestran with--external)