-
-
Couldn't load subscription status.
- Fork 104
feat: REL task #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: REL task #114
Conversation
Co-authored-by: kadarakos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work!
# Conflicts: # usage_examples/tests/test_usage_examples.py
|
I adjusted the usage examples (and usage example tests) style to be in line with the other ones. I noticed that there is a Thinc deprecation warning happening in the tests however - let me see if I can reproduce it in the GH CI. |
|
Ah, and first we need to add |
otherwise multiprocessing won't work
|
Ok so for now let's leave it as it is? It requires quite an important change to use |
|
Add |
|
Ah, wait, no that won't quite work, either. Let me just write a util method... |
|
Great, thanks for the help @adrianeboyd! I think it's finally ready. |
Co-authored-by: Adriane Boyd <[email protected]>
|
@bdura Before you merge, run the external tests again? (Locally or GH, doesn't matter) |
Still some failures. Thanks, I'll investigate. |
Description
This PR adds a new REL task.
Types of change
This is a feature.
Checklist
externaland thoserequiring a GPU. I did this for the following directories:
testsusage_example/tests