Remove error suppressor in async_utils.py and engine.py #2362
+5
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link / Problem Description
Problem: Errors during testset generation transforms were being silently caught and suppressed
Changes Made
src/ragas/async_utils.py
: Removed exception suppression inprocess_futures()
function (lines 93-95)result = e
)src/ragas/testset/transforms/engine.py
: Removed exception suppression inrun_coroutines()
function (line 61)logger.error(...)
)Why these changes:
Testing
How to Test
generator.generate_with_langchain_docs()
orapply_transforms()
BadRequestError: temperature not supported
)ValueError: Node X has no summary_embedding
later in the pipelineExample test case (reproduces original issue):
References