Skip to content

fix: answer_relevancy scoring logic to prevent false zero #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

fix: answer_relevancy scoring logic to prevent false zero #2327

merged 1 commit into from
Sep 30, 2025

Conversation

anistark
Copy link
Contributor

Issue Link / Problem Description

Changes Made

  • fixed answer_relevancy scoring logic to prevent false zero scores for valid answers

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 29, 2025
@anistark anistark mentioned this pull request Sep 29, 2025
Open
jjmachan
jjmachan approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@jjmachan jjmachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjmachan jjmachan merged commit 4026f4f into explodinggradients:main Sep 30, 2025
9 checks passed
@anistark anistark deleted the fix/noncommittal branch October 6, 2025 14:52
@anistark anistark mentioned this pull request Oct 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjmachan jjmachan jjmachan approved these changes

Assignees

No one assigned

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

why answer_relavancy getting nan and sometime get 0. why is that?

2 participants

@anistark @jjmachan