fix: improve metric decorators with better validation and error handling #2302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the metric decorator system (
discrete_metric
,numeric_metric
,ranking_metric
) with improved input validation, better error messages, and support for both plain value returns andMetricResult
objects.Key Changes
1. Automatic MetricResult Wrapping
MetricResult
objectsMetricResult
objects directly for cases where custom reasons are needed2. Enhanced Input Validation with Pydantic
3. Improved Async/Sync Handling
ragas.async_utils.run
4. Direct Callable Support
metric()
returns the raw function resultmetric.score()
returns aMetricResult
object with validation5. Better MetricResult Representation
__repr__
to show both value and reason when presentTesting
test_metric_decorators.py
) covering:Breaking Changes
None - the changes are backward compatible. Existing code using MetricResult returns will continue to work.
Benefits
🤖 Generated with Claude Code