Skip to content

Ensure old_temperature is set correctly. Fixes #1937 and #2110 #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 22, 2025
Merged

Ensure old_temperature is set correctly. Fixes #1937 and #2110 #2295

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c60a0b
Ensure old_temperature is set correctly. Fixes #1937 and #2110
claudepi Sep 20, 2025
65d3ea0
Added '# type: ignore' comment to allow type checker to pass
claudepi Sep 21, 2025
30e102f
Fixed up after running Ruff's auto-format
claudepi Sep 21, 2025
00fc9af
Changed default temperature from None to 0.01
claudepi Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ragas/llms/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,8 @@ def generate_text(
if temperature is None:
temperature = self.get_temperature(n=n)
if hasattr(self.langchain_llm, "temperature"):
old_temperature = self.langchain_llm.temperature # type: ignore
self.langchain_llm.temperature = temperature # type: ignore
old_temperature = temperature

if is_multiple_completion_supported(self.langchain_llm):
result = self.langchain_llm.generate_prompt(
Expand Down Expand Up @@ -268,8 +268,8 @@ async def agenerate_text(
if temperature is None:
temperature = self.get_temperature(n=n)
if hasattr(self.langchain_llm, "temperature") and not self.bypass_temperature:
old_temperature = self.langchain_llm.temperature # type: ignore
self.langchain_llm.temperature = temperature # type: ignore
old_temperature = temperature

# handle n
if hasattr(self.langchain_llm, "n"):
Expand Down
Loading