Enhance EmbeddingExtractor to support both async and sync methods for… #2286
Conversation
… embedding extraction - Updated the EmbeddingExtractor class to check if the embedding model supports async operations. - If async is supported, it uses the async method `aembed_text`; otherwise, it falls back to the sync method `embed_text`. - This change improves flexibility and compatibility with different client implementations.
dosubot
bot
added
the
size:S
|
hey @telesoho thank you so much for raising the fix ❤️ would you fix the CI issue if you get a chance, we'll love to merge it in after that. also I was wondering if I could learn more about how you are using testset generation - we are planning to do some improvements to it and would love your feedback on it. can you share a few timeslots that work or a calendar I can use? alternatively this is mine if it helps https://cal.com/jjmachan/huddle |
- Updated the EmbeddingExtractor class to enhance code readability by standardizing string quotes and formatting. - Adjusted the conditional checks for async support to improve clarity and maintainability. - These changes contribute to a cleaner codebase while preserving existing functionality.
|
Hi @jjmachan, thanks for the quick feedback! Regarding testset generation, I’m using Ragas to automatically create test sets from an Odoo model and business-documentation knowledge base to evaluate retrieval + generation accuracy. Thanks again for reviewing and maintaining this project! |
- Updated the conditional check for async support in the EmbeddingExtractor class to improve readability. - The check now uses `getattr` to safely access the `is_async` attribute, ensuring it defaults to False if not present. - These changes enhance code maintainability while preserving existing functionality.
- Added a warning when using a synchronous embedding model in an asynchronous context to inform users about potential performance impacts. - Wrapped the synchronous embedding method in a thread executor to prevent blocking, improving compatibility with async workflows. - These changes enhance the flexibility of the EmbeddingExtractor while maintaining existing functionality.
3 participants
… embedding extraction
aembed_text; otherwise, it falls back to the sync methodembed_text.Issue Link / Problem Description
Screenshots/Examples (if applicable)