Feature: improve relationship builders for better async and reduced memory utilization #2077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ahgraber
commented
Jun 13, 2025
ahgraber
commented
- CosineSimilarityBuilder now uses a sharded/chunked similarity calculation to significantly reduce memory requirements
- CosineSimilarityBuilder and JaccardSimilarityBuilder now leverage generate_execution_plan to support async iteration over tasks (for potential future multithreading or improved concurrency)
- Added unit tests
dosubot
bot
added
the
size:XXL
ahgraber
force-pushed
the
feature/relationship-builder
branch
2 times, most recently
from
fb608d0 to
d30e58d
Compare
|
Thanks for the PR @ahgraber |
|
@anistark - I've merged the changes from upstream |
|
It works on my computer (TM). |
anistark
requested changes
Sep 1, 2025
There was a problem hiding this comment.
@ahgraber There's several breaking changes. Can we have backwards compatibility for _find_similar_embedding_pairs:
- extra param changing the method signature. Try default value for the extra param.
- sync to async conversion. Probably better to provide both sync and async versions.
- return type change from List -> Set. Is there a pure benefit or we can use Set internally and keep List for backwards compatibility.
Also, we got rid of experimental. Please rebase once more and align with latest changes.
…methods - Refactored the JaccardSimilarityBuilder to use async methods for finding similar embedding pairs. - Introduced a new method `generate_execution_plan` to generate coroutines of comparisons for better tracking and potential concurrency - Updated the `transform` method to utilize the new async functionality. - Added comprehensive test coverage for the new features in the JaccardSimilarityBuilder.
- Improved logic for generating similar and dissimilar sets based on input constraints.
- keep _find_similar_embedding_pairs as sync - _find_similar_embedding_pairs should return List
ahgraber
force-pushed
the
feature/relationship-builder
branch
from
301d9c7 to
0917aea
Compare
dosubot
bot
added
size:XL
- remove block_size parameter from _find_similar_embedding_pairs and use CosineSimilarityBuilder attribute
|
@anistark I've cleanly rebased. Re: requested changes:
|
|
/claude-review |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.