feature: improve async / executor functionality #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
|
I know this one is a big review - everything's interrelated enough that I had a hard time splitting it up, but I could try to refactor into smaller pulls if necessary. |
ahgraber
changed the title
ahgraber
changed the title
dosubot
bot
added
size:XXL
ahgraber
force-pushed
the
feature/async-executor
branch
from
ecfdfcd to
d5bdcc3
Compare
|
@ahgraber Thanks for the PR. Could you please try rebase and check for the conflicts? |
ahgraber
force-pushed
the
feature/async-executor
branch
from
c68f37c to
4b7774f
Compare
This helps separate async features from executor and engine modules, and will prevent circular imports in these modules.
Introduces a new ProgressBarManager class to manage progress bars for both batch and non-batch execution. This includes methods for creating single and nested progress bars, as well as updating batch progress bars, improving user experience during long-running tasks.
- Refactored `run` function from repeated async, executor, and engine logic. - Changed `as_completed` from async to a regular function for better compatibility. - Added `process_futures` to handle futures with optional progress tracking.
- Refactored Executor to utilize new async_utils and ProgressBarManager for improved composition - Refactored run_async_tasks to utilize ProgressBarManager for improved progress tracking. - Modified tests to validate the new behavior functions
- Introduced a locking mechanism to ensure thread-safe job processing. - Added `_jobs_processed` attribute to maintain consistent job indexing across multiple runs. - Implemented `clear_jobs` method to reset job indices. - Updated tests to verify exception handling and job indexing after clearing jobs. - Adjusted Jupyter notebook tests for consistency in results retrieval.
…sted Transformation or Parallel procedures - The apply_transforms() function has been updated to handle different types of transformations recursively: If transforms is a list, it recursively applies each transform in the list. If transforms is a Parallel instance, it recursively applies the transformations contained within the Parallel object. If transforms is a BaseGraphTransformation, it generates an execution plan (a list of coroutines), gets a description, and then runs the coroutines asynchronously using run_async_tasks(). If transforms is none of the above, it raises a ValueError indicating an invalid type. - Move apply_nest_asyncio to async_utils for better organization - Updated the Parallel class to support transformations with improved type hints. - Added unit tests
…e Executor - nest_asyncio has internal checks for whether it is applied, rely on those - Ensured apply_nest_asyncio is called in the Executor class to handle nested event loops.
- Removed optional progress bar parameter from process_futures. - Updated calls to process_futures to handle progress bar updates directly. - Cleaned up error handling logic for results in async processing.
- Replaced event loop checks with a unified async wrapper for scoring. - Simplified error handling and callback management. - Ensured compatibility with Jupyter environments by applying nest_asyncio directly.
ahgraber
force-pushed
the
feature/async-executor
branch
from
4b7774f to
ad79704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps separate async features from executor and engine modules, and will prevent circular imports in these modules.
Introduces a new ProgressBarManager class to manage progress bars for both batch and non-batch execution. This includes methods for creating single and nested progress bars, as well as updating batch progress bars, improving user experience during long-running tasks.
runfunction from repeated async, executor, and engine logic.as_completedfrom async to a regular function for better compatibility.process_futuresto handle futures with optional progress tracking._jobs_processedattribute to maintain consistent job indexing across multiple runs.clear_jobsmethod to reset job indices.If transforms is a list, it recursively applies each transform in the list.
If transforms is a Parallel instance, it recursively applies the transformations contained within the Parallel object.
If transforms is a BaseGraphTransformation, it generates an execution plan (a list of coroutines), gets a description, and then runs the coroutines asynchronously using run_async_tasks().
If transforms is none of the above, it raises a ValueError indicating an invalid type.