Skip to content

Conversation

licux
Copy link
Contributor

@licux licux commented Feb 1, 2025

This pull request is related to issue #1893

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 1, 2025
@jjmachan
Copy link
Member

jjmachan commented Feb 4, 2025

thanks a lot for putting in a PR @licux 🙁
@sahusiddharth can you take a look?

Copy link
Contributor

@anistark anistark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @licux

However the tests are failing. Could you please rebase and check ci issues. You can run them locally with: make run-ci

@anistark anistark linked an issue Aug 25, 2025 that may be closed by this pull request
@anistark anistark added the blocked Blocked on further action label Aug 28, 2025
@anistark anistark merged commit 8e7ead0 into explodinggradients:main Sep 1, 2025
18 of 19 checks passed
@anistark anistark removed the blocked Blocked on further action label Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect calculation at ToolCallAccuracy

3 participants