Update: isort pre-commit hook #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `pre-commit run --all-files` on ref `6df4751`, the current `main` branch, fails to complete and reports the foll in the error: [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$' I _think_ this is related to PyCQA/isort#2079. I'm proposing that we update to the same isort that the isort repo currently uses.
choldgraf
approved these changes
Apr 6, 2023
Member
choldgraf
left a comment
choldgraf
left a comment
There was a problem hiding this comment.
LGTM - thanks for updating it. For some reason I don't see the "approve to run github actions" button, but I think it's probably fine given that this is just a pre-commit hook and it's broken right now
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
pre-commit run --all-filesonref
6df4751, the currentmainbranch,fails to complete and reports the foll in
the error:
This seems to be the same error as PyCQA/isort#2077.
I'm proposing that we update to the same isort
that the isort repo currently uses.