Skip to content

feat: add support for private docker registries #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2022

Conversation

tylerslaton
Copy link
Collaborator

@tylerslaton tylerslaton commented Aug 14, 2022

Summary

This PR adds the ability to specify the username and password to use when authenticating against a registry. It does this by adding two new flags:

  • --username, -u
  • --password, -p

In addition, the --content-path short name has been updated to be -c (from -p as that seems more fitting for --password).

Review Notes

  1. This currently only supports writing your username/password to the console. Its fine to have this as is but we should also come up with a better way of using the docker config so that users can do this more securely locally. This is likely a good follow-up.
  2. There is the ability for us to add another flag that specifies what server to use but it felt superfluous as it defaults to wherever the image is stored. I'd be happy to update it if we want that.
  3. I did not add tests here as the bloat for testing private registries would delay this feature. I'd prefer get this through and worry about that complex testing logic later.

Closes #1

@tylerslaton tylerslaton requested a review from exdx August 14, 2022 17:46
@tylerslaton tylerslaton force-pushed the private-docker-registry branch from 39ddb57 to 243e65a Compare August 14, 2022 17:48
@tylerslaton tylerslaton force-pushed the private-docker-registry branch from 243e65a to bde8f37 Compare August 14, 2022 18:21
@tylerslaton tylerslaton force-pushed the private-docker-registry branch from bde8f37 to e7cc9d6 Compare August 14, 2022 18:30
@exdx
Copy link
Owner

exdx commented Aug 14, 2022

For some reason the test status is hung up -- I will manually merge

@exdx
Copy link
Owner

exdx commented Aug 14, 2022

Thanks for the PR!

@exdx exdx merged commit 61b7f8b into exdx:main Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for pulling private images
2 participants