lib: add support for podman container runtime #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Still some issues to iron out regarding the borrow checker |
exdx
force-pushed
the
podman-support
branch
5 times, most recently
from
4e3649b to
91a5811
Compare
exdx
force-pushed
the
podman-support
branch
7 times, most recently
from
7486ea4 to
bbec9c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for podman. Initially I tried to write a completely generic solution, but quickly ran into issues because the methods provided on the container type are functions instead of traits. Going that route would require writing a trait for every function call required by the container type. It seemed like a lot of work. Instead, I took a simpler route and encapsulated both runtimes as part of a custom type.
Closes #26
TODO: