Skip to content

Conversation

bugloper
Copy link
Contributor

@bugloper bugloper commented Sep 22, 2024

Add publish_gem Github Action

@bugloper bugloper changed the title Add automatic release with google release please feat: automatic release using release-please Sep 22, 2024
@bugloper bugloper force-pushed the release-please-action branch from 6989a99 to f3cb80e Compare September 22, 2024 09:28
@bugloper bugloper marked this pull request as ready for review September 22, 2024 09:28
@bugloper
Copy link
Contributor Author

@excid3 Please check once.

@excid3
Copy link
Owner

excid3 commented Sep 22, 2024

@bugloper I didn't know about this Google action.

I was actually thinking we should use Rubygems trusted publishing like we do in Pay. Probably could just copy this over: https://github.com/pay-rails/pay/blob/main/.github/workflows/publish_gem.yml

@bugloper
Copy link
Contributor Author

https://github.com/pay-rails/pay/blob/main/.github/workflows/publish_gem.yml

Oh, sure. Will add it

@bugloper bugloper changed the title feat: automatic release using release-please Add publish_gem Github Action Sep 22, 2024
@bugloper
Copy link
Contributor Author

bugloper commented Sep 22, 2024

At the company I work for currently, we are migration from wicked_pdf to gotenberg. So, I created this gem called gotenberg. I didn't know about ferrum until now.
https://rubygems.org/gems/gotenberg

@excid3
Copy link
Owner

excid3 commented Sep 22, 2024

I saw gotenberg mentioned in a GitHub Issue earlier. Looks like a great project!

@excid3 excid3 merged commit bf474e2 into excid3:main Sep 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants