Skip to content

Conversation

@lutfuahmet
Copy link
Contributor

This pull request introduces a configurable timeout feature for http client. The default timeout is set to 15 seconds, but users can now modify it by utilizing the HTTP_TIMEOUT environment variable.

@mms-gianni mms-gianni merged commit 3918cf3 into everywall:main Dec 7, 2023
@dkbednarczyk
Copy link
Contributor

dkbednarczyk commented Dec 7, 2023

@mms-gianni this PR ignores the error from strconv.Atoi, if the environment variable is set to "15s" instead of just "15", the variable won't do anything. For invalid values we should warn the user that it would be ignored.

andesco pushed a commit to andesco/ladder that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants