Skip to content

Conversation

SeWaS
Copy link
Contributor

@SeWaS SeWaS commented Dec 3, 2024

Related to #907, might even close #907.

This PR provides the capabilities to EventFlow to apply naming strategies which can ensure that no collisions among events with the same class name but different namespaces occur.

There are a few built-in strategies, users can provide their own strategy by simply implementing the IEventNamingStrategy interface.

The desired naming strategy needs to be registered to the DI container, otherwise a ViodStrategy is registered as default, which represents the current naming strategy.

Also, I added a simple and small README for the documentation.

Copy link
Member

@rasmus rasmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Many thanks for the PR, just some minor comments and nitpicks.

… in EventFlowConfiguration, renaming of VoidStrategy to Defaultstrategy, using string interpolation in naming strategies
@SeWaS SeWaS requested a review from rasmus December 7, 2024 08:56
@rasmus rasmus merged commit 0400395 into eventflow:develop-v1 Dec 8, 2024
5 checks passed
@rasmus
Copy link
Member

rasmus commented Dec 8, 2024

❤️

@rasmus
Copy link
Member

rasmus commented Dec 8, 2024

I'll get this added, update release notes and released

@SeWaS SeWaS deleted the issue/907/event-naming-strategy branch December 8, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Supply another mechanism for event naming
2 participants