Skip to content

In sequence.c, start/end parameter check is corrected for arrays since specifying start>end caused a segmentation fault. #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2018
Merged

In sequence.c, start/end parameter check is corrected for arrays since specifying start>end caused a segmentation fault. #285

merged 1 commit into from
Jul 11, 2018

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Jul 6, 2018

No description provided.

@k-okada
In sequence.c, start/end parameter check is corrected for arrays
2d49786 
       since specifying start>end caused a segmentation fault.
@k-okada k-okada mentioned this pull request Jul 6, 2018
Merged
@k-okada k-okada merged commit ae68f76 into euslisp:master Jul 11, 2018
@k-okada k-okada deleted the fix_sequence branch July 11, 2018 12:04
This was referenced Jul 12, 2018
Merged
Merged
@k-okada
Copy link
Member Author

k-okada commented Jul 12, 2018

This PR is correct, obey CommonLisp specification , but causes significant impact on roseus users,
#291 and jsk-ros-pkg/jsk_roseus#568
So I think we'd better to revert #293 for now.

see #293 for more detail

@k-okada k-okada restored the fix_sequence branch July 17, 2018 09:15
@k-okada k-okada mentioned this pull request Jul 17, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@k-okada