Skip to content

Conversation

@rawmain
Copy link
Contributor

@rawmain rawmain commented Jul 30, 2025

Issue

Original README of the project listed API Level 28 (Android 9/P) as the minimum supported SDK.

However, the original project value for minSdk was actually API Level 31 (Android 12/S) - check KotlinAndroid.kt file in build-logic - according to supported API declarations for version 0.2.2 of eudi-lib-android-rqes-ui library.

Indeed, by just lowering minSdk value from 31 to 29 without making any further edits, builds of all variants/flavors failed with the following error messages :

C:\XPMODEFILES\AGEv\av-app-android-wallet-ui-min_API29\app\src\main\AndroidManifest.xml Error:
	uses-sdk:minSdkVersion 29 cannot be smaller than version 31 declared in library [eu.europa.ec.eudi:eudi-lib-android-rqes-ui:0.2.2] C:\Users\utente\.gradle\caches\8.11.1\transforms\d05aedf071a6c56ca52b88748ab4e650\transformed\eudi-lib-android-rqes-ui-0.2.2\AndroidManifest.xml as the library might be using APIs not available in 29
	Suggestion: use a compatible library with a minSdk of at most 29,
		or increase this project's minSdk version to at least 31,
		or use tools:overrideLibrary="eu.europa.ec.eudi.rqesui" to force usage (may lead to runtime failures)
		
Manifest merger failed : uses-sdk:minSdkVersion 29 cannot be smaller than version 31 declared in library [eu.europa.ec.eudi:eudi-lib-android-rqes-ui:0.2.2] C:\Users\utente\.gradle\caches\8.11.1\transforms\d05aedf071a6c56ca52b88748ab4e650\transformed\eudi-lib-android-rqes-ui-0.2.2\AndroidManifest.xml as the library might be using APIs not available in 29
	Suggestion: use a compatible library with a minSdk of at most 29,
		or increase this project's minSdk version to at least 31,
		or use tools:overrideLibrary="eu.europa.ec.eudi.rqesui" to force usage (may lead to runtime failures)

Description of changes

  • Reduced Project build-logic minSdk from API Level 31 (Android 12/S) to API Level 29 (Android 10/Q)

  • Upgraded AGP from 8.10.1 to 8.11.0 (gradle 8.11.1 -> 8.13)

  • Bumped EUDI RQES UI library version from 0.2.2 to 0.2.3 in order to fully support minSdk=29

  • Bumped versions of other project deps in order to align with rqes-ui deps changes from version 0.2.2 to 0.2.3

Ref in libs.versions.toml Original Version Fix Version
androidGradlePlugin 8.10.1 8.11.0
androidxAppCompat 1.7.0 1.7.1
androidxComposeBom 2025.05.1 2025.06.1
androidxLifecycle 2.9.0 2.9.1
kotlin 2.1.21 2.2.0
ksp 2.1.21-2.0.1 2.2.0-2.0.2
robolectric 4.14.1 4.15.1
turbine 1.2.0 1.2.1
koin 4.0.4 4.1.0
koinAnnotations 2.0.1-RC1 2.1.0
owaspDependencyCheck 12.1.1 12.1.3
rqesUiSDK 0.2.2 0.2.3

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other fix (maintenance or house-keeping)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test suite run successfully
  • Added Tests ()

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked that my views are accessible
  • I have checked that my strings are localized where applicable

Resolves #34

rawmain added 2 commits July 30, 2025 04:15
Original README listed API Level 28 (Android 9/P) as the minimum supported SDK.

However, the original project value for minSdk was 31 (Android 12/S) - check KotlinAndroid.kt file in build-logic - according to supported API declarations for version 0.2.2 of eudi-lib-android-rqes-ui library.

Fixed and updated the value to 29 - according to code changes made to support minSdk=29 (see subsequent commits).
- Reduced Project build-logic minSdk from 31 to 29

- Upgraded AGP from 8.10.1 to 8.11.0

- Bumped EUDI RQES UI library version from 0.2.2 to 0.2.3 in order to support minSdk=29

- Bumped versions of other project deps in order to align with rqes-ui deps changes from version 0.2.2 to 0.2.3
rawmain added 2 commits July 31, 2025 16:18
OS Build check if dynamic theming is supported. Dynamic color is available on Android 12/S+
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2025

Copy link
Contributor

@paulinabls paulinabls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@paulinabls paulinabls merged commit f902148 into eu-digital-identity-wallet:main Aug 8, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minSdk project/libraries mismatch

2 participants