Skip to content

onItemClick id is incorrect #69

@davejohncole

Description

@davejohncole

https://github.com/etsy/AndroidStaggeredGrid/blob/master/library/src/main/java/com/etsy/android/grid/ExtendableListView.java#L2744

The position argument to performItemClick is offset by mFirstPosition, but the argument passed to adapter.getItemId() is not offset.

I think the line should be:

performItemClick(view, motionPosition + mFirstPosition, adapter.getItemId(motionPosition + mFirstPosition));

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions