Add additional Tls/SSL arguments #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etianen
requested changes
Jun 15, 2024
Owner
etianen
left a comment
etianen
left a comment
There was a problem hiding this comment.
This looks good! I've made some doc suggestions for consistency, but otherwise looks great.
Owner
|
I've allowed workflows for this PR so you can check linting and tests. You'll also need to resolve some conflicts on the readme. Nice work though, so I'll be happy to merge this after these tweaks! ❤️ |
Co-authored-by: Dave Hall <[email protected]>
Co-authored-by: Dave Hall <[email protected]>
Co-authored-by: Dave Hall <[email protected]>
Co-authored-by: Dave Hall <[email protected]>
Contributor
Author
Thanks! I've applied the changes now. |
etianen
reviewed
Jul 29, 2024
Owner
|
Merged, and will shortly be released! |
Owner
|
Published as 0.15.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running an LDAP server with a handful of old/legacy settings required, which causes this to fail to connect. Pullrequest adds support for entering those settings, and support for other unnamed options through keyword arguments.