Skip to content

fix(provider): Check if value is already wrapped in fallback provider #5059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(provider): Check if value is already wrapped in fallback provider #5059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b28a1ac
fix: make fallback provider to check if value is block already before…
hastom Oct 21, 2025
7b38240
Fix formatting
hastom Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib.commonjs/providers/provider-fallback.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import { AbstractProvider } from "./abstract-provider.js";
import { Network } from "./network.js";
import type { PerformActionRequest } from "./abstract-provider.js";
import type { Networkish } from "./network.js";
import type { BlockParams } from "./formatting.js";
import { Block } from "./provider.js";
/**
* A configuration entry for how to use a [[Provider]].
*/
Expand Down Expand Up @@ -105,6 +107,7 @@ export declare class FallbackProvider extends AbstractProvider {
constructor(providers: Array<AbstractProvider | FallbackProviderConfig>, network?: Networkish, options?: FallbackProviderOptions);
get providerConfigs(): Array<FallbackProviderState>;
_detectNetwork(): Promise<Network>;
_wrapBlock(value: BlockParams, network: Network): Block;
/**
* Transforms a %%req%% into the correct method call on %%provider%%.
*/
Expand Down
2 changes: 1 addition & 1 deletion lib.commonjs/providers/provider-fallback.d.ts.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions lib.commonjs/providers/provider-fallback.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib.commonjs/providers/provider-fallback.js.map
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions lib.esm/providers/provider-fallback.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import { AbstractProvider } from "./abstract-provider.js";
import { Network } from "./network.js";
import type { PerformActionRequest } from "./abstract-provider.js";
import type { Networkish } from "./network.js";
import type { BlockParams } from "./formatting.js";
import { Block } from "./provider.js";
/**
* A configuration entry for how to use a [[Provider]].
*/
Expand Down Expand Up @@ -105,6 +107,7 @@ export declare class FallbackProvider extends AbstractProvider {
constructor(providers: Array<AbstractProvider | FallbackProviderConfig>, network?: Networkish, options?: FallbackProviderOptions);
get providerConfigs(): Array<FallbackProviderState>;
_detectNetwork(): Promise<Network>;
_wrapBlock(value: BlockParams, network: Network): Block;
/**
* Transforms a %%req%% into the correct method call on %%provider%%.
*/
Expand Down
2 changes: 1 addition & 1 deletion lib.esm/providers/provider-fallback.d.ts.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions lib.esm/providers/provider-fallback.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib.esm/providers/provider-fallback.js.map
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions src.ts/providers/provider-fallback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import { Network } from "./network.js"

import type { PerformActionRequest } from "./abstract-provider.js";
import type { Networkish } from "./network.js"
import type { BlockParams } from "./formatting.js";
import { Block } from "./provider.js";

const BN_1 = BigInt("1");
const BN_2 = BigInt("2");
Expand Down Expand Up @@ -442,6 +444,13 @@ export class FallbackProvider extends AbstractProvider {
// throw new Error("@TODO");
//}

_wrapBlock(value: BlockParams, network: Network): Block {
if (value instanceof Block) {
return value;
}
return super._wrapBlock(value, network);
}

/**
* Transforms a %%req%% into the correct method call on %%provider%%.
*/
Expand Down