Skip to content

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Apr 25, 2025

This removes the storage key from the step trace as Danno confirmed that this field is not used and will be removed from EIP-7756.

It also adds back an optimization in regarding codeSizes that was accidentally removed in #3953

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.55%. Comparing base (3d520fa) to head (02a5975).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 84.33% <ø> (ø)
blockchain 89.32% <ø> (ø)
client 67.99% <ø> (ø)
common 97.51% <ø> (ø)
devp2p 86.78% <ø> (ø)
evm 73.13% <100.00%> (+0.01%) ⬆️
mpt 89.69% <ø> (-0.42%) ⬇️
statemanager 69.06% <ø> (ø)
static 99.11% <ø> (ø)
tx 90.59% <ø> (ø)
util 89.36% <ø> (ø)
vm 55.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jochem-brouwer
jochem-brouwer previously approved these changes Apr 25, 2025
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Please merge once CI passes (assuming it does)

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@jochem-brouwer jochem-brouwer merged commit f740102 into master Apr 25, 2025
40 checks passed
@jochem-brouwer jochem-brouwer deleted the remove-storage-from-trace branch April 25, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants