-
Notifications
You must be signed in to change notification settings - Fork 835
util: remove undefined handling from bytesToHex #4004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see changes to the account
file (which is good!), could you directly deprecate the constructor of Account and document that createAccount
should be used? Context: #3958. I think it's fine to also do that in this PR and not create a new one, since it's only docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM! 🙂 🙏
This PR fixes #3998 by updating bytesToHex so that it throws on undefined instead of returning
0x
Fixes #3958 by deprecating the account constructor and updating the docs.