Skip to content

Conversation

gabrocheleau
Copy link
Contributor

@gabrocheleau gabrocheleau commented Apr 20, 2025

This PR fixes #3998 by updating bytesToHex so that it throws on undefined instead of returning 0x
Fixes #3958 by deprecating the account constructor and updating the docs.

Copy link

codecov bot commented Apr 20, 2025

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.51%. Comparing base (aba2ffc) to head (281a423).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 83.34% <ø> (ø)
blockchain 89.32% <ø> (ø)
client 67.99% <85.71%> (+0.03%) ⬆️
common 97.51% <ø> (ø)
devp2p 86.78% <ø> (ø)
evm 73.03% <ø> (ø)
mpt 89.45% <ø> (+0.05%) ⬆️
statemanager 69.08% <ø> (ø)
static 99.11% <ø> (ø)
tx 90.59% <ø> (ø)
util 89.36% <96.29%> (-0.17%) ⬇️
vm 55.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see changes to the account file (which is good!), could you directly deprecate the constructor of Account and document that createAccount should be used? Context: #3958. I think it's fine to also do that in this PR and not create a new one, since it's only docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@gabrocheleau gabrocheleau marked this pull request as ready for review April 22, 2025 03:08
@gabrocheleau gabrocheleau requested a review from acolytec3 April 22, 2025 18:57
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 🙂 🙏

@holgerd77 holgerd77 merged commit d2fbe9a into master Apr 23, 2025
40 checks passed
@holgerd77 holgerd77 deleted the util/bytesToHex-undefined-case branch April 23, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected handling of undefined in bytesToHex Argument of type 'BigIntLike' is not assignable... in Account.ts

3 participants