Skip to content

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Apr 18, 2025

Closes #3986

WIP, TODOs:

  • Remove unused error messages in EOFError error message map
  • Move the EVMErrorMessages object into the EVMError constructor class as a static field
  • Verify that the casing of error-related params like EvmErrorResult are correct (should be EVMErrorResult)
  • Make errorType on EVMError a constant somewhere and export it such that is reads from that variable? Then if we change it in the future, we don't run in the similar problem

@jochem-brouwer jochem-brouwer changed the title evm/vm: use constant as string to ref for EVMError EVM: cleanup error messages and fix styling Apr 18, 2025
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 61.00000% with 78 lines in your changes missing coverage. Please review.

Project coverage is 79.52%. Comparing base (20cae2b) to head (9671973).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 83.34% <ø> (ø)
blockchain 89.32% <ø> (ø)
client 67.95% <ø> (ø)
common 97.51% <ø> (ø)
devp2p 86.78% <ø> (ø)
evm 73.03% <61.00%> (-0.07%) ⬇️
mpt 89.71% <ø> (-0.06%) ⬇️
statemanager 69.08% <ø> (ø)
static 99.11% <ø> (ø)
tx 90.59% <ø> (ø)
util 89.53% <ø> (ø)
vm 55.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@am1r021 am1r021 force-pushed the evm-error-cleanup branch from 8f1ee90 to 9671973 Compare April 21, 2025 03:58
@am1r021 am1r021 marked this pull request as ready for review April 21, 2025 04:15
Copy link
Member Author

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just realized that I opened this PR so I can't approve it 😅

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 77bf2e9 into master Apr 21, 2025
39 of 40 checks passed
@holgerd77 holgerd77 deleted the evm-error-cleanup branch April 21, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused evm error messages and move error messages map object into constructor class

3 participants