Skip to content

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Mar 25, 2025

This PR fixes the gas calculation in 7702.

It also removes the extraCost param from the legacy getDataGas, this param has no use, one can just add the extraCost to whatever the method returns.

This PR now passes https://github.com/ethereum/execution-spec-tests/releases/tag/pectra-devnet-6%40v1.0.0

Side note: we need a CI job or a tool which allows us to run these tests on the CI. The CI currently does not run the latest Prague tests.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.86%. Comparing base (b1f8cbc) to head (1b33c5b).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 76.95% <ø> (ø)
blockchain 83.81% <ø> (ø)
client 68.05% <ø> (ø)
common 91.58% <ø> (ø)
devp2p 76.38% <ø> (-0.07%) ⬇️
evm 69.18% <ø> (ø)
genesis 99.84% <ø> (ø)
mpt 61.20% <ø> (-0.04%) ⬇️
rlp 69.32% <ø> (ø)
statemanager 67.21% <ø> (ø)
tx 80.92% <66.66%> (ø)
util 79.14% <ø> (ø)
vm 57.31% <ø> (ø)
wallet 84.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 94e5a0d into master Mar 25, 2025
39 of 41 checks passed
@holgerd77 holgerd77 deleted the fix-pectra branch March 25, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants