Skip to content

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Mar 24, 2025

Closes #3929

WIP

TODO:

  • Integrate these utility methods in vm/runTx
  • Add example to show how to init a 7702 tx
  • Add tests
  • Change authorizationListJSONToBytes to no work on authorizationListItem[] but instead work on authorizationListItem, because now there is this awkward authorizationListJSONToBytes([item])[0] to convert an element. Also for Bytes -> JSON
  • Add TX package cleanup #3890 (comment)

@jochem-brouwer jochem-brouwer marked this pull request as draft March 24, 2025 16:04
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 78.99160% with 25 lines in your changes missing coverage. Please review.

Project coverage is 75.87%. Comparing base (94e5a0d) to head (796a11c).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 76.95% <ø> (ø)
blockchain 83.81% <ø> (ø)
client 68.05% <ø> (?)
common 91.58% <ø> (ø)
devp2p 76.45% <ø> (?)
evm 69.18% <ø> (ø)
genesis 99.84% <ø> (ø)
mpt 61.20% <ø> (ø)
rlp 69.32% <ø> (ø)
statemanager 67.21% <ø> (ø)
tx 80.93% <78.44%> (+<0.01%) ⬆️
util 79.14% <ø> (ø)
vm 57.20% <100.00%> (-0.12%) ⬇️
wallet 84.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jochem-brouwer
Copy link
Member Author

jochem-brouwer commented Mar 24, 2025

I think we can delete example this https://github.com/ethereumjs/ethereumjs-monorepo/blob/tx-authlist-signing/packages/tx/examples/EOACodeTx.ts.

Hmm no nvm it's referenced in the README/Changelog

@jochem-brouwer
Copy link
Member Author

I ran the pectra tests locally, they pass. Open for review 👍 😄

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really marvellous, especially this setEOATx.tsexample! 🤩

Feel free to merge, needed to re-trigger a failing devp2p test.

@jochem-brouwer jochem-brouwer merged commit 900bb2f into master Mar 25, 2025
68 of 78 checks passed
@jochem-brouwer jochem-brouwer deleted the tx-authlist-signing branch March 25, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EIP-7702 support: add signing individual authorizations

2 participants