Skip to content

Conversation

@jochem-brouwer
Copy link
Member

Cherry-picked from #1910, original author: @holgerd77

Related: #3712

@codecov
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (4470cc3) to head (2f904ab).
Report is 81 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4470cc3) and HEAD (2f904ab). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (4470cc3) HEAD (2f904ab)
block 1 0
client 1 0
tx 1 0
Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block ?
client ?
tx ?
wallet 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabrocheleau
Copy link
Contributor

Same Q as with #3714 , @jochem-brouwer do you have a view on if our error handling should be improved at this stage, or is status-quo sufficinet?

@jochem-brouwer
Copy link
Member Author

I remember this PR, this is cherry-picked from the original, the code is from @holgerd77.

I think if we want to improve Block errors this would be a way to start (this PR should rather be treated as to be opened by Holger). Also part of error messages issue #3712

@holgerd77
Copy link
Member

Let's please leave open for now for inspiration until we get a bit more of a start on this second half of error integration, so when we replace all these EthereumJSErrorWithoutCode placeholders @jochem-brouwer laid the ground for with the real/final stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants