Util: Static Constructors for Withdrawals & Requests (Tree Shaking) #3589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In-between feedback: this looks good so far |
Ran out of time before the weekend. Will finish this up today |
ScottyPoi
force-pushed
the
util-treeshake
branch
from
17cf69d to
86c2463
Compare
ScottyPoi
added
PR state: needs review
type: refactor
package: util
breaking
target: master
am1r021
reviewed
Aug 23, 2024
packages/util/src/request.ts
Outdated
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable @typescript-eslint/no-use-before-define */ | |||
There was a problem hiding this comment.
Could disabling no-use-before-define be avoided?
packages/util/src/withdrawal.ts
Outdated
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable @typescript-eslint/no-use-before-define */ | |||
There was a problem hiding this comment.
Same thing here, could disabling no-use-before-define be avoided?
holgerd77
previously requested changes
Aug 26, 2024
|
Please update the example embeddings in the |
|
Can this be finalized so that we can merge? |
ScottyPoi
force-pushed
the
util-treeshake
branch
from
c11d5b3 to
109670f
Compare
added 10 commits
August 27, 2024 11:21
ScottyPoi
force-pushed
the
util-treeshake
branch
from
109670f to
2c368ea
Compare
added 2 commits
August 27, 2024 11:44
|
changes addressed. ready for re-review |
|
Nice, looks good! 🙂 |
holgerd77
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Util treeshaking task cleanup from #3560
withdrawal.tsWithdrawalstatic constructors extracted to functionsrequests.tsrenamedrequest.tsWithdrawalRequestConsolidationRequestDepositRequest