-
Notifications
You must be signed in to change notification settings - Fork 835
VM: runTx(), runBlock(), buildBlock() Standalone Methods #3530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
I think this should be ready for review now. Small side note, upon checking EDIT: will go ahead and do this |
Can you do in a separate PR please? |
Ok, went ahead and also moved This will only help if the end user only uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! 👏
(will admin-merge)
Addresses #3522
First round on replacing the VM core class based methods with function calls by remove the bindings.
Feel free to pick up if wanted!