Skip to content

verkle: migrate from rust-verkle-wasm to verkle-cryptography-wasm #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 33 commits into from

Conversation

gabrocheleau
Copy link
Contributor

This PR removes the rust-verkle-wasm dependency and replaces it with the verkle-cryptography-wasm dep.

@gabrocheleau gabrocheleau added type: refactor dependencies Pull requests that update a dependency file target: master Work to be done towards master branch package: verkle labels Mar 11, 2024
@gabrocheleau gabrocheleau self-assigned this Mar 11, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 90 lines in your changes are missing coverage. Please review.

Project coverage is 85.03%. Comparing base (4be68d2) to head (679c67f).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block ?
blockchain 90.92% <ø> (ø)
client ?
common 94.02% <ø> (ø)
devp2p ?
evm 72.67% <0.00%> (-0.64%) ⬇️
genesis 99.98% <ø> (ø)
statemanager ?
trie 59.62% <ø> (+0.02%) ⬆️
tx ?
util ?
vm ?
wallet ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer
Copy link
Member

Making PUSH opcodes from sync -> async benchmark, see 8b67d14

Async version (new)

----BENCHMARK: PUSH OPCODES----
	Start run 1
	Took 4699.186103820801ms
	Start run 2
	Took 4831.999346733093ms
	Start run 3
	Took 4710.368566989899ms
	Start run 4
	Took 4697.478115081787ms
	Start run 5
	Took 4690.3551597595215ms

Sync version (old, master)

----BENCHMARK: PUSH OPCODES----
	Start run 1
	Took 3969.890606880188ms
	Start run 2
	Took 4116.379570007324ms
	Start run 3
	Took 4266.281263828278ms
	Start run 4
	Took 4263.075453281403ms
	Start run 5
	Took 4154.331348896027ms

Note: this bench the extreme case of how many PUSH opcodes I managed to squeeze into 30M gas, but as can be seen the result is definitely measurable.

@acolytec3 acolytec3 force-pushed the verkle/add-verkle-cryptography-wasm-dep branch from 07ffdc2 to a6c38a2 Compare April 1, 2024 23:11
@acolytec3 acolytec3 force-pushed the verkle/add-verkle-cryptography-wasm-dep branch from 099a4a0 to 6bb236a Compare April 2, 2024 00:13
@gabrocheleau
Copy link
Contributor Author

Closing in favor of #3356

@holgerd77 holgerd77 deleted the verkle/add-verkle-cryptography-wasm-dep branch July 11, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file package: verkle target: master Work to be done towards master branch type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants