p2p/discover: remove hot-spin in table refresh trigger #32912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
force-pushed
the
p2p-discover-refresh-debounce
branch
from
c6aa3fb to
3868d86
Compare
kmk142789
approved these changes
Oct 14, 2025
cskiraly
reviewed
Oct 14, 2025
|
|
||
| now := time.Now() | ||
| diff := now.Sub(it.lastLookup) | ||
| it.lastLookup = now |
There was a problem hiding this comment.
just nitpicking, but something like the following would be more precise:
defer func() { it.lastLookup = time.Now() }()
Anyway, the current one works as well for the scope here.
cskiraly
approved these changes
Oct 14, 2025
11221973
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #32518. In that PR, we removed the slowdown logic that would throttle lookups when the table runs empty. Said logic was originally added in #20389.
Usually it's fine, but there exist pathological cases, such as hive tests, where the node can only discover one other node, so it can only ever query that node and won't get any results. In cases like these, we need to throttle the creation of lookups to avoid crazy CPU usage.