Fix 1753 fork criteria #1760
Open
Fix 1753 fork criteria #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chetna-mittal
pushed a commit
to gnosischain/execution-specs
that referenced
this pull request
Nov 8, 2025
… pre-allocation group terminology (ethereum#1760) * refactor(docs): move `engine_reorg` -> `engine_x` * refactor(all): rename 'engine reorg' to 'engine x' * refactor(all): update lang from 'shared pre-alloc' to 'pre-allocation groups' 1/2 Terminology: - 'shared pre-allocation' → 'pre-allocation groups' - 'shared pre-state' → 'pre-allocation groups' Flags: - `--generate-shared-pre` -> `--generate-grouped-pre-allocs` - `--use-shared-pre` -> `--use-grouped-pre-allocs` Method names updated: - `update_shared_pre_state` → `update_pre_alloc_groups` - `compute_shared_pre_alloc_hash` → `compute_pre_alloc_group_hash` - `shared_pre_alloc_folder_path` → `grouped_pre_allocs_folder_path` * refactor(all): update lang from 'shared pre-alloc' to 'pre-allocation groups' 2/2 * docs: update changelog * refactor(filler): rename flags for consistency with class names Rename command-line flags to align with function and class naming: - --generate-grouped-pre-allocs → --generate-pre-alloc-groups - --use-grouped-pre-allocs → --use-pre-alloc-groups This improves consistency with PreAllocGroups class and related method names throughout the codebase. Updated all flag definitions, config.getoption() calls, property names, and documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR explicitly annotates the FORK_CRITERIA variable with the ForkCriteria supertype across all fork definition files (src/ethereum/forks/*/init.py). This addresses a type-checking issue where the narrower type (e.g., ByBlockNumber) was being inferred, which could lead to API breakage when transitioning to a broader type (e.g., ByTimestamp).
🔗 Related Issues or PRs
Fixes #1753
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture