Skip to content

Conversation

@fselmo
Copy link
Contributor

@fselmo fselmo commented Nov 3, 2025

🗒️ Description

Working on BAL tests and specs and then merging EEST into EELS with forks/osaka as the base branch made it so that Osaka inherited the BAL changes. We develop EIPs in separate branches targeted toward the appropriate forks they should be in. So that others can work on top of forks/amsterdam without BAL support, some of these checks should be turned off so that they don't get validation issues. These removals will need to be added into eips/amsterdam/eip-7928 (BAL feature working branch) to turn these back on. I will PR the changes to add these checks back in there.

I didn't turn everything off as that would be a very large sweeping change, but this should get others unstuck from the constraints related to BAL checks. cc: @LouisTsai-Csie if you can check that this works for your benchmarking branch, that would be great.

What I did to check this is to cherry pick this change to forks/amsterdam locally and ran uv run fill --clean --fork=Amsterdam and this seems to resolve all the fails that were happening related to BAL checks. Hopefully this is the minimal changeset required to get others unstuck.


Note: This will require re-creating forks/amsterdam from forks/osaka and I can handle this as well once this is approved and merged.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Screenshot 2025-11-03 at 10 03 54

@fselmo fselmo added C-bug Category: this is a bug, deviation, or other problem A-test-tests Area: tests for execution spec tests labels Nov 3, 2025
@fselmo fselmo force-pushed the fix/remove-bal-checks-in-osaka branch 2 times, most recently from 33d6cb6 to bc6598e Compare November 3, 2025 17:01
@fselmo fselmo marked this pull request as ready for review November 3, 2025 17:04
@fselmo fselmo marked this pull request as draft November 3, 2025 17:10
@fselmo fselmo force-pushed the fix/remove-bal-checks-in-osaka branch from bc6598e to 68cdfa4 Compare November 3, 2025 17:21
- Remove BAL-specific checks in Osaka so we have a cleaner implementation
  of Amsterdam when re-creating. This was a remnant of working on tests
  and specs separately but then merging the repos together implementation
  ``forks/osaka`` as the base branch.
@fselmo fselmo force-pushed the fix/remove-bal-checks-in-osaka branch from 68cdfa4 to 8204ed4 Compare November 3, 2025 18:01
@fselmo fselmo marked this pull request as ready for review November 3, 2025 18:03
@fselmo fselmo added A-test-forks Area: execution spec tests forks A-test-fixtures Area: execution spec tests fixtures package A-test-specs Area: execution spec tests specs package labels Nov 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (1078413) to head (e60c8d5).
⚠️ Report is 1 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           forks/osaka    #1737   +/-   ##
============================================
  Coverage        86.08%   86.08%           
============================================
  Files              743      743           
  Lines            44072    44072           
  Branches          3891     3891           
============================================
  Hits             37938    37938           
  Misses            5656     5656           
  Partials           478      478           
Flag Coverage Δ
unittests 86.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LouisTsai-Csie
Copy link
Collaborator

Thanks @fselmo , i checkout this branch and create the amsterdam fork for testing, and benchmark tests are working now!

@fselmo fselmo requested a review from marioevz November 4, 2025 16:10
@fselmo fselmo removed the A-test-tests Area: tests for execution spec tests label Nov 4, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although it seemed to me that there must be a way for these changes to exist in forks/osaka without affecting test filling, because the BAL code should be completely inactive when filling for earlier forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-fixtures Area: execution spec tests fixtures package A-test-forks Area: execution spec tests forks A-test-specs Area: execution spec tests specs package C-bug Category: this is a bug, deviation, or other problem P-high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants