-
Notifications
You must be signed in to change notification settings - Fork 401
Add tracing support for daemon #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ah, it looks like there's an edit: I added a comment on the related EEST PR as well. Might be worth PRing the EEST changes to the branch with |
404435b to
3f8ad1c
Compare
846a8be to
4ab6a46
Compare
This problem is on EEST's side, we'll take care of it there. More background here: ethereum/execution-spec-tests#1174 (comment) |
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny comment, but overall works great for EEST.
- If ``trace`` is passed in the POST, turn on full trace in the T8N tool. - Validate that ``output-basedir`` is also specified as EEST relies on a known location for the trace files. Raise a clarifying error if it is not specified.
4ab6a46 to
7f0e751
Compare
feat(tests): EOF - EIP-7620: verify RETURNCONTRACT does not overwrite containing contract
What was wrong?
Related to ethereum/execution-spec-tests#1174
Tracing is not currently working via daemon when
--tracesis passed via EEST when filling tests.How was it fixed?
traceis passed in the POST, turn on full trace in the T8N tool.output-basediris also specified as EEST relies on a known location for the trace files. Raise a clarifyingerror if it is not specified.
Cute Animal Picture