fillers/eips/eip3860: Update EIP-3860 Due to Small Spec Change #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Still to add extra checks to catch OOG error. Similar to -> (link) |
#25) * tests: add framework tests for the compute_create*_address helpers * tests: fix type hint in test_compute_create2_address function args
Collaborator
Author
|
I have made a mess. |
marioevz
added a commit
to marioevz/execution-spec-tests
that referenced
this pull request
Jan 31, 2024
Co-authored-by: danceratopz <[email protected]>
spencer-tb
referenced
this pull request
in spencer-tb/execution-spec-tests
Feb 1, 2024
Co-authored-by: danceratopz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if there is an initcode length violation for 'CREATE'/'CREATE2' the gas for the initcode execution is not deducted but stored. In the new spec change here -> link the evm exceptionally aborts as if it runs out of gas. A small fix is added to achieve the latter.
Another small change is added to match the salt addition here -> (link)