Skip to content

feat(ci): Add devnet-6 definitions #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marioevz merged 2 commits into from
Jan 29, 2025
Merged

feat(ci): Add devnet-6 definitions #1156

marioevz merged 2 commits into from
Jan 29, 2025

Conversation

@marioevz
Copy link
Member

@marioevz marioevz commented Jan 29, 2025 •
edited
Loading

🗒️ Description

Changes devnet-5 to devnet-6 in all relevant CI config files.

🔗 Related Issues

#1108

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:ci Scope: Continuous Integration type:chore Type: Chore labels Jan 29, 2025
@marioevz marioevz requested a review from danceratopz January 29, 2025 20:10
@marioevz marioevz mentioned this pull request Jan 29, 2025
Closed
10 tasks
@danceratopz danceratopz changed the title feat(github): Add devnet-6 definitions feat(ci): Add devnet-6 definitions Jan 29, 2025
danceratopz
danceratopz approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

danceratopz
danceratopz approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks even better.

@marioevz
Copy link
Member Author

marioevz commented Jan 29, 2025

Merging now since devnet-5 v1.3.1 has been tagged and is already building.

@marioevz marioevz merged commit 8808a3e into main Jan 29, 2025
21 checks passed
@marioevz marioevz deleted the add-devnet-6-ci-info branch January 29, 2025 21:15
marioevz added a commit to marioevz/execution-spec-tests that referenced this pull request Jan 30, 2025
@marioevz
feat(ci): Add devnet-6 definitions (ethereum#1156)
ef06474 
* feat(github): Add devnet-6 definitions

* eels_resolutions: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danceratopz danceratopz danceratopz approved these changes

Assignees

No one assigned

Labels

scope:ci Scope: Continuous Integration type:chore Type: Chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marioevz @danceratopz