engine: Remove engine_getPayloadBodiesBy{Hash|Range}V2 #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexstokes
approved these changes
Sep 18, 2024
Member
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
I think we added this for early Pectra, and if it was just to handle the pruned execution requests we can definitely drop it now
as we refactored the execution requests so they are no longer pruned
Redidacove
pushed a commit
to Redidacove/execution-apis
that referenced
this pull request
Sep 30, 2024
Remove engine_getPayloadBodiesBy{Hash|Range}V2
This was referenced Oct 15, 2024
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Oct 25, 2024
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
engine_getPayloadBodiesByHashV2andengine_getPayloadBodiesByRangeV2methods assuming that CL clients will keep requests in its databases due to ethereum/consensus-specs#3875, thus requesting this data from EL is no longer requiredResolves ethereum/consensus-specs#3912