disallow VALID <-> INVALID equivocation
#493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkalinin
reviewed
Nov 22, 2023
mkalinin
reviewed
Dec 7, 2023
Co-authored-by: Mikhail Kalinin <[email protected]>
mkalinin
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially copies over https://github.com/ethereum/consensus-specs/blob/v1.4.0-beta.4/sync/optimistic.md#transitioning-from-valid---invalidated-or-invalidated---valid into more execution-layer specs.
The current specs don't use a verb much to describe the specific process of determination of
VALID, et cetera, but more the whole response construction. The one time I could find they unambiguously do, that verb is "classify", so went with that.The intent here is to disallow this equivocation even over time, i.e. for any given
newPayloador fcU, by construction it can't equivocate, and simply being incorrect indefinitely is not great either, but then that EL is just broken, in more significant ways.The harm/fallout/externality that's resulting from this is exactly that for basically ephemeral reasons, ELs are responding
INVALID, thenVALID, but by then from a CL perspective it can be too late.Phrasing it this way avoids reference to some ground truth state, requiring only relative comparisons and constraints.