This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Feature/eip 145 #1167
Merged
Feature/eip 145 #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Oops, VMTest is running with FrontierConfig. I'll fix it. |
mkalinin
suggested changes
Aug 24, 2018
Contributor
mkalinin
left a comment
mkalinin
left a comment
There was a problem hiding this comment.
I agree with you on breaking down VMTest into several test files. We can divide them by opcode semantics
| * @return this << arg | ||
| */ | ||
| public DataWord shiftLeft(DataWord arg) { | ||
| BigInteger result = value().shiftLeft(arg.value().intValue()); |
Contributor
There was a problem hiding this comment.
It's better to use intValueSafe() here to avoid undesirable overflow
| DataWord word1 = program.stackPop(); | ||
| DataWord word2 = program.stackPop(); | ||
| final DataWord result; | ||
| if (word1.value().compareTo(BigInteger.valueOf(256)) < 0) { |
Contributor
There was a problem hiding this comment.
This and following checks (in other similar instructions) is better to move to DataWord class cause they also make sense for DataWord itself
mkalinin
approved these changes
Aug 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mkalinin please, take a look!
Also I'd separate VMTest to several smaller tests, what do you think?