Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Wallet.sol: change to onlymanyowners modifier breaks administrative functions #81

@brynbellomy

Description

@brynbellomy

I think the most recent change to wallet.sol broke all of the administrative functions (i.e., those with the onlymanyowners modifier).

See relevant commit + line: 2849dab#diff-ed99a3039a35a9961cc9c6735a7099baR49

confirmAndCheck returns either true or false depending on whether or not the function call has been approved by M-of-N owners. However, regardless of return value, it makes important state changes that count the confirmations received thus far. The new implementation of onlymanyowners reverts state changes (via require) any time confirmAndCheck returns false, making it impossible to hit the confirmation threshold for any function. No tallying ever happens.

This makes it impossible to change any of the wallet's properties such as ownership, required confirmations, etc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions