-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Distributed Blob Publishing to Fulu networking spec #4183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jtraglia
merged 17 commits into
ethereum:dev
from
jimmygchen:distributed-blob-publishing
Mar 28, 2025
Merged
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ebec514
Add distributed blob publishing section to Fulu p2p interface spec.
jimmygchen 2739e5f
Apply suggestions from code review
jimmygchen a027ff6
Apply suggestions from code review
jimmygchen a74fa60
Fix lint
jimmygchen 78bde87
Fix lint.
jimmygchen 6ec7d3f
Merge branch 'dev' into distributed-blob-publishing
jimmygchen f798950
Add new line before list
jtraglia 43892f0
Clarify columns that clients must publish to in Distributed Publishing.
jimmygchen dc25211
add function to retrieve sidecars from both block and sidecar
fradamt 34706cf
fix lint
fradamt 3a232f6
fix lint again
fradamt f208942
fix tests
fradamt b81b6eb
Fix tests & nits
jtraglia b57e22a
Fix more nits
jtraglia 053f03b
Merge branch 'dev' into distributed-blob-publishing
jimmygchen f32d33d
Address review comment.
jimmygchen c76082d
clarify language
fradamt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've concerns on requiring it from all. If your custody requirement is just 4, it sounds like too much to follow all these rules and spend computation power. I'd bound it to supernodes only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also home staker on ADSL wouldn't be happy to try to publish all DataColumns with 48, 64 etc blobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full nodes won't actually send all data columns - they only send data columns on topics they're subscribed to. This is the same behaviour as if you receive a data column via gossip - you'd spend the bandwidth to propagate it to mesh peers.
If the node ever add the columns to the "gossip seen cache" without publishing / forwarding the column, it would stop propagation of the columns to the rest of the network.
re 1st point about computing columns - proofs will no longer be computed in the CL, so this would be a cheap operation, and potentially makes the block available sooner than waiting for columns to arrive from gossip.