Skip to content

Conversation

ralexstokes
Copy link
Member

this constant is no longer needed in the spec proper, and is only used to generate sample test data

let's drop it from the spec (e.g. to reduce cognitive load on readers) and just define it near use in the testing code.

@hwwhww hwwhww added presentation Presentation (as opposed to content) deneb labels Oct 28, 2023
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@ppopth ppopth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@djrtwo djrtwo merged commit 9b1e0b7 into ethereum:dev Oct 30, 2023
@ralexstokes ralexstokes deleted the clean-up-deneb-tx-type branch October 30, 2023 17:28
ralexstokes added a commit to ralexstokes/ethereum-consensus that referenced this pull request Nov 5, 2023
SummerRolf added a commit to SummerRolf/ethereum-consensus that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deneb presentation Presentation (as opposed to content)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants