Opti sync: how to apply latestValidHash when payload is INVALID
#2954
+51
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
reviewed
Jul 27, 2022
Contributor
|
LGTM. This matches how Teku is interpreting things now. |
Contributor
|
It would be great to get approvals/confirmations from Lighthouse (@paulhauner @michaelsproul), Lodestar (@dapplion @tuyennhv), and Nimbus (@etan-status @arnetheduck @tersec) too. 🙏 |
Merged
5 tasks
djrtwo
approved these changes
Aug 1, 2022
twoeths
approved these changes
Aug 2, 2022
Contributor
Author
|
Last call for approval from @paulhauner and @tersec, merging in 24 hours |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies on how to handle
latestValidHashon CL side. This PR doesn't introduce any breaking changes but instead makes current CL behaviour into the spec and leaves recommendation on what to do whenlatestValidHashcan't be found in a block treeUPD
It's written in a way that uses
latestValidHashto only invalidate blocks. No valid semantics oflatestValidHashis leveraged by this PRcc @potuz @ajsutton @paulhauner