Skip to content

Maybe we should verify the FFG vote target in p2p beacon_aggregate_and_proof screening  #2111

@lucianyao

Description

@lucianyao

We don't verify the FFG vote target when screening message beacon_aggregate_and_proof, as we do when screening beacon_attestation_{subnet_id}:

[REJECT] The attestation's epoch matches its target -- i.e. 
attestation.data.target.epoch == compute_epoch_at_slot(attestation.data.slot)

[REJECT] The attestation's target block is an ancestor of the block named in the LMD vote -- i.e. 
get_ancestor(store, 
    attestation.data.beacon_block_root, 
    compute_start_slot_at_epoch(attestation.data.target.epoch)) == 
attestation.data.target.root

( also there is no verification in process_attestation, but I think it's not able to do it)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions